代码优化

performance-web/src/main/java/com/clx/performance/service/impl/trace/TruckTraceMqHandlerServiceImpl.java

@@ -14,6 +14,7 @@ import com.clx.performance.service.trace.TruckTraceMqHandlerService;
 import com.clx.performance.utils.LocalDateTimeUtils;
 import com.clx.performance.utils.zjxl.ZjxlGpsService;
 import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
@@ -40,13 +41,21 @@ public class TruckTraceMqHandlerServiceImpl implements TruckTraceMqHandlerServic
     @Transactional(rollbackFor = Exception.class)
     @Override
     public void truckTracSync(TruckTraceSyncMqParam mq) {
-        VehicleWarnChild vehicleWarnChild = vehicleWarnChildDao.findByChildNo(mq.getChildNo()).orElseThrow(ResultEnum.DATA_NOT_FIND);
 
-        OrderChild orderChild = orderChildDao.getByChildNo(mq.getChildNo()).orElseThrow(ResultEnum.DATA_NOT_FIND);
-        if (orderChild.getFinishTime() != null) {
-            vehicleWarnChild.setTraceStatus(VehicleWarnChildEnum.TraceStatus.DISABLE.getCode());
+        if (StringUtils.isNotBlank(mq.getChildNo())) {
+            VehicleWarnChild vehicleWarnChild = vehicleWarnChildDao.findByChildNo(mq.getChildNo()).orElseThrow(ResultEnum.DATA_NOT_FIND);
+
+            OrderChild orderChild = orderChildDao.getByChildNo(mq.getChildNo()).orElseThrow(ResultEnum.DATA_NOT_FIND);
+            if (orderChild.getFinishTime() != null) {
+                vehicleWarnChild.setTraceStatus(VehicleWarnChildEnum.TraceStatus.DISABLE.getCode());
+            }
+            vehicleWarnChild.setTraceTime(LocalDateTimeUtils.parseTime(mq.getEndTime()));
+
+            // 更新同步时间
+            if (StringUtils.isNotBlank(mq.getChildNo())) {
+                vehicleWarnChildDao.updateTraceTime(vehicleWarnChild);
+            }
         }
-        vehicleWarnChild.setTraceTime(LocalDateTimeUtils.parseTime(mq.getEndTime()));
 
         List<TruckTraceDTO> list = zjxlGpsService.getTruckTrace(mq.getTruckNo(), mq.getBeginTime(), mq.getEndTime());
         if (list.isEmpty()) {return;}
@@ -67,9 +76,6 @@ public class TruckTraceMqHandlerServiceImpl implements TruckTraceMqHandlerServic
 
         // 保存
         truckTraceESPlusMapper.insertBatch(esList);
-
-        // 更新同步时间
-        vehicleWarnChildDao.updateTraceTime(vehicleWarnChild);
     }
 
 }