Merge branch 'bug_sonar_20240426' into dev

performance-web/src/main/java/com/clx/performance/job/OrderNoGenerateJob.java

@@ -94,7 +94,7 @@ public class OrderNoGenerateJob implements InitializingBean {
             try {
                 jsonTemplate.opsForList().leftPushAll(key, data.subList(i, j));
             } catch (Exception e){
-                e.printStackTrace();
+                log.error(e.getMessage());
                 continue;
             }
         }
@@ -158,7 +158,7 @@ public class OrderNoGenerateJob implements InitializingBean {
                 try {
                     generateOrderNo();
                 } catch (Exception e) {
-                    e.printStackTrace();
+                    log.error(e.getMessage());
                 }
             }
         });

performance-web/src/main/java/com/clx/performance/service/impl/IntegralMqHandlerServiceImpl.java

@@ -577,7 +577,7 @@ public class IntegralMqHandlerServiceImpl implements IntegralMqHandlerService {
      */
     private Integer diffSecond(LocalDateTime startTime, LocalDateTime endTime){
         Duration duration = Duration.between(startTime, endTime);
-        return Long.valueOf(duration.getSeconds()).intValue();
+        return (int)duration.getSeconds();
     }
 
 }

performance-web/src/main/java/com/clx/performance/service/impl/IntegralStatisticsServiceImpl.java

@@ -77,7 +77,7 @@ public class IntegralStatisticsServiceImpl implements IntegralStatisticsService
     private int diffDay(LocalDateTime beginDate, LocalDateTime endDate){
         long day = Duration.between(beginDate, endDate).toDays();
 
-        return Long.valueOf(day).intValue();
+        return (int)day;
     }
 
 }

performance-web/src/main/java/com/clx/performance/service/impl/thirdparty/nbbank/NbBankThirdpartyServiceImpl.java

@@ -67,19 +67,15 @@ public class NbBankThirdpartyServiceImpl implements NbBankThirdpartyService {
      */
     private static void downloadUsingStream(String urlStr, String file) throws IOException {
         URL url = new URL(urlStr);
-        BufferedInputStream bis = null;
-        FileOutputStream fis = null;
-        try {
-            bis = new BufferedInputStream(url.openStream());
-            fis = new FileOutputStream(file);
+        try (InputStream inputStream = url.openStream();
+             BufferedInputStream bis = new BufferedInputStream(inputStream);
+             FileOutputStream fis = new FileOutputStream(file)) {
+
             byte[] buffer = new byte[1024];
             int count = 0;
             while ((count = bis.read(buffer, 0, 1024)) != -1) {
                 fis.write(buffer, 0, count);
             }
-        }finally {
-            if (fis != null){fis.close();}
-            if (bis != null){bis.close();}
         }
     }